[v12.x] n-api: create N-API version 7#35337
Closed
gabrielschulhof wants to merge 1 commit intonodejs:v12.x-stagingfrom
Closed
[v12.x] n-api: create N-API version 7#35337gabrielschulhof wants to merge 1 commit intonodejs:v12.x-stagingfrom
gabrielschulhof wants to merge 1 commit intonodejs:v12.x-stagingfrom
Conversation
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs#35199 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <mdawson@devrus.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
c++
gengjiawen
approved these changes
Sep 25, 2020
legendecas
approved these changes
Sep 26, 2020
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
Landed in b9d0f73 |
addaleax
pushed a commit
that referenced
this pull request
Sep 28, 2020
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #35199 Backport-PR-URL: #35337 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <mdawson@devrus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark
napi_detach_arraybufferandnapi_is_detached_arraybufferasstable.
Signed-off-by: @gabrielschulhof
PR-URL: #35199
Reviewed-By: @cjihrig
Reviewed-By: @gengjiawen
Reviewed-By: @legendecas
Reviewed-By: @mhdawson
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes